mockServer/src/services/pages.js (2)

34-37: Redundant unique index on _id.

NeDB automatically enforces uniqueness on _id by default. This explicit index declaration has no effect and can be removed.

♻️ Suggested fix

-    this.db.ensureIndex({
-      fieldName: '_id',
-      unique: true
-    })

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mockServer/src/services/pages.js` around lines 34 - 37, Remove the redundant
explicit unique index creation on `_id` by deleting the this.db.ensureIndex({
fieldName: '_id', unique: true }) call in the pages service (where this.db is
initialized). NeDB enforces uniqueness for `_id` automatically, so remove that
ensureIndex invocation (or guard it with a comment if you want to retain
historical context) and keep any other index setup intact.

---

111-120: Consider adding route conflict validation to update as well.

The create method now validates route uniqueness per app, but update does not. If a page's route is updated to conflict with another page in the same app, the duplicate will be allowed.

For consistency, consider adding similar validation when params.route is being changed.

♻️ Suggested fix

   async update(id, params) {
     const updateData = { ...params }
+
+    if (updateData.route) {
+      const current = await this.db.findOneAsync({ _id: id })
+      if (current) {
+        const existing = await this.db.findOneAsync({
+          app: current.app.toString(),
+          route: updateData.route,
+          _id: { $ne: id }
+        })
+        if (existing) {
+          return getResponseData(null, {
+            code: 'ROUTE_CONFLICT',
+            message: `Route "${updateData.route}" already exists in app "${current.app}"`
+          })
+        }
+      }
+    }
+
     if (updateData.page_content && typeof updateData.page_content === 'object') {
       updateData.page_content = JSON.stringify(updateData.page_content)
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mockServer/src/services/pages.js` around lines 111 - 120, The update method
(async update(id, params)) needs the same route-uniqueness check as create: when
params.route is provided and differs from the current page's route, query the DB
for any other document with the same app and route (e.g., this.db.findOneAsync({
app: existing.app, route: params.route, _id: { $ne: id } })); if such a document
exists, throw/return a conflict error instead of proceeding to
this.db.updateAsync; otherwise proceed to stringify page_content as currently
done, update, and return getResponseData(parsePageContent(result)).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes